-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stdlib documentation #339
Stdlib documentation #339
Conversation
Co-authored-by: Hubert Jabłoński <hubik080@gmail.com>
Co-authored-by: Hubert Jabłoński <hubik080@gmail.com>
Co-authored-by: Hubert Jabłoński <hubik080@gmail.com>
Co-authored-by: Hubert Jabłoński <hubik080@gmail.com>
Co-authored-by: Hubert Jabłoński <hubik080@gmail.com>
Co-authored-by: Hubert Jabłoński <hubik080@gmail.com>
Co-authored-by: Hubert Jabłoński <hubik080@gmail.com>
Co-authored-by: Hubert Jabłoński <hubik080@gmail.com>
Co-authored-by: Hubert Jabłoński <hubik080@gmail.com>
Co-authored-by: Hubert Jabłoński <hubik080@gmail.com>
Co-authored-by: Hubert Jabłoński <hubik080@gmail.com>
we will discuss in a ticket about the error handling
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I see now. Let's wait for the PR first
I removed the part that create the dependency cycle so we can merge the documentation in the meantime
So it is ready to get approved :-) |
what about the #360? i dont think that has been addressed yet |
Now the PR is free from that issue as I removed the code (the CI works). |
I think that can create confusion. |
Let's move it to separate issue. I think that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good
* feat(doc): stdlib first incomplete version * feat(doc): stdlib first incomplete version * feat(review): by @CymDeveloppement * feat(review): by @CymDeveloppement * Update src/std/array.ab Co-authored-by: Hubert Jabłoński <hubik080@gmail.com> * Update src/std/text.ab Co-authored-by: Hubert Jabłoński <hubik080@gmail.com> * Update src/std/text.ab Co-authored-by: Hubert Jabłoński <hubik080@gmail.com> * Update src/std/text.ab Co-authored-by: Hubert Jabłoński <hubik080@gmail.com> * Update src/std/env.ab Co-authored-by: Hubert Jabłoński <hubik080@gmail.com> * Update src/std/env.ab Co-authored-by: Hubert Jabłoński <hubik080@gmail.com> * Update src/std/fs.ab Co-authored-by: Hubert Jabłoński <hubik080@gmail.com> * Update src/std/fs.ab Co-authored-by: Hubert Jabłoński <hubik080@gmail.com> * Update src/std/http.ab Co-authored-by: Hubert Jabłoński <hubik080@gmail.com> * Update src/std/text.ab Co-authored-by: Hubert Jabłoński <hubik080@gmail.com> * Update src/std/text.ab Co-authored-by: Hubert Jabłoński <hubik080@gmail.com> * Update src/std/text.ab Co-authored-by: Hubert Jabłoński <hubik080@gmail.com> * feat(review): by @KrosFire * feat(review): by @KrosFire * feat(review): text and remove in_array * feat(review): by @CymDeveloppement * fix(std): remove dependence so we can merge the documentation in the meantime * fix(test): wip * fix(test): wip * fix(test): wip * fix(test): wip * fix(test): wip * Update text.ab --------- Co-authored-by: Hubert Jabłoński <hubik080@gmail.com>
Ref: amber-lang/amber-docs#38
I need a bit of help to improve the documentation also because I didn't understood the purpose of some function.
I think that @CymDeveloppement can help me about it as some of them are by him.