-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add date function to stdlib #348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- If you use "Succeded" as output for the test you don't need the output.txt file
- We aren't using tabs for codestyle but 4 spaces
- For comments the first letter of the sentence in uppercase
- A test fails because the CI uses a different timezone
The timezone now it is the same but the time is different for an hour. |
Can we merge it? |
I think so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea to add date
but this module will change entirely when we add enums
where people will be able to easily choose values like day
, month
etc. This module should be marked as experimental in the documentation as it will evolve very rapidly
Where we can write that is experimental in the file for the documentation? |
|
IF you can add that so we can merge this PR |
this PR add date function to stdlib :
date
display a date with a special format withgnu date
command formathttps://www.gnu.org/software/coreutils/date
now
return current timestamp as Numdate_add
add days/month/years ... to datedate_add("200-01-01", "+122 days")
date_compare
compare 2 date (a/b) and return 1 if a is after b, 0 if a and b is the same date, -1 if b is after athis function can compare 2 date with différent format.