feat(stdlib): add new functions in std/text
#373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `reverse`: reverses the given text. - `is_prefix`: checks if a string is a prefix of another string. - `is_suffix`: checks if a string is a suffix of another string. These addition of `is_prefix` & `is_suffix` complement the existing `contains` function.
|
I would prefer |
Mte90
approved these changes
Jul 30, 2024
|
shouldn't we use |
Indeed it is better! |
is_prefix -> starts_with is_suffix -> ends_with
MuhamedMagdi
force-pushed
the
feat/std-text
branch
from
51ce178 to
fa15f13
Compare
|
updated but i think there is something wrong with the |
b1ek
approved these changes
Jul 31, 2024
Mte90
pushed a commit
to Mte90/Amber
that referenced
this pull request
Sep 19, 2024
* feat(stdlib): add new functions in `std/text` - `reverse`: reverses the given text. - `is_prefix`: checks if a string is a prefix of another string. - `is_suffix`: checks if a string is a suffix of another string. These addition of `is_prefix` & `is_suffix` complement the existing `contains` function. * refactor: change `is_prefix` & `is_suffix` function names is_prefix -> starts_with is_suffix -> ends_with
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reverse: reverses the given text.starts_with: checks if a string is a prefix of another string.ends_with: checks if a string is a suffix of another string.The addition of
starts_with&ends_withcomplement the existingcontainsfunction.