Test Nix on CI #385
Merged
Test Nix on CI #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThetaSinner
commented
Aug 1, 2024
ThetaSinner
commented
Aug 1, 2024
ThetaSinner
commented
Aug 1, 2024
ThetaSinner
commented
Aug 1, 2024
ThetaSinner
commented
Aug 1, 2024
| nativeBuildInputs = [ toolchain ]; | ||
| RUST_SRC_PATH = rustPlatform.rustLibSrc; | ||
| ] ++ [ toolchain ]; | ||
| RUST_SRC_PATH = toolchain.availableComponents.rust-src; |
There was a problem hiding this comment.
This part I'm not sure about, I assume this is for VSCode integration? I don't have that or know how to check if this is still making Rust's source code available for inspection with RLS
There was a problem hiding this comment.
This seems to be necessary for rust-analyzer, for the development environment. See https://discourse.nixos.org/t/rust-src-not-found-and-other-misadventures-of-developing-rust-on-nixos/11570
Trying to run rust-analyzer from the dev environment, I get another problem though:
(nix:nix-shell-env) mks@Navi:~/Projects/amber$ rust-analyzer
error: Unknown binary 'rust-analyzer' in official toolchain 'stable-x86_64-unknown-linux-gnu'.
Mte90
approved these changes
Aug 1, 2024
Ph0enixKM
approved these changes
Aug 6, 2024
Bonniemarie216
approved these changes
Aug 15, 2024
Mte90
pushed a commit
to Mte90/Amber
that referenced
this pull request
Sep 19, 2024
* Build Nix package on CI * Resolve duplicate inputs and flake update * Switch to rust-overlay * Check that the `bc` command is included and set path works correctly * Exit if check fails * Move Nix checks to its own workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was recently unable to build because of the wrapProgram issue #359. That is now resolved, but it would be good to test that Amber is building correctly with Nix on CI. I've added a workflow job to do that.
I also noticed that you have duplicate nixpkgs coming in through naersk. I have configured naersk to use the same nixpkgs as the Amber project is using.