Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A65 Feature: Add named function Imports #41

Merged
merged 2 commits into from
Oct 5, 2022
Merged

A65 Feature: Add named function Imports #41

merged 2 commits into from
Oct 5, 2022

Conversation

Ph0enixKM
Copy link
Member 

import { foo } from 'path'
import { foo as bar } from 'path'

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 5, 2022
View reviewed changes
src/modules/imports/import.rs Outdated
for export_unit in exports.clone() {
match export_unit {
ExportUnit::Function(mut func) => {
if &func.name == &name {

Check failure

Code scanning / clippy

needlessly taken reference of both operands

needlessly taken reference of both operands
src/modules/imports/import.rs Outdated
ExportUnit::Function(mut func) => {
if &func.name == &name {
found = true;
func.name = alias.unwrap_or(name.clone());

Check failure

Code scanning / clippy

use of `unwrap_or` followed by a function call

use of `unwrap_or` followed by a function call
@Ph0enixKM Ph0enixKM merged commit b1ee744 into master Oct 5, 2022
@Ph0enixKM Ph0enixKM deleted the A65 branch October 5, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Ph0enixKM