Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change unsafe keywords to trust #498

Merged
merged 4 commits into from
Oct 4, 2024
Merged

Change unsafe keywords to trust #498

merged 4 commits into from
Oct 4, 2024

Conversation

Ph0enixKM
Copy link
Member

@Ph0enixKM Ph0enixKM commented Oct 1, 2024 •
edited
Loading

I changed unsafe to trust keyword and added a warning when unsafe is used (in which case it's used as if trust keyword was used).

@Ph0enixKM Ph0enixKM requested review from Mte90 and hdwalters October 1, 2024 09:15
@Ph0enixKM Ph0enixKM linked an issue Oct 1, 2024 that may be closed by this pull request
[Feature] Change unsafe keyword to trust #296
Closed
3 tasks
hdwalters
hdwalters requested changes Oct 1, 2024
View reviewed changes
src/modules/command/modifier.rs Show resolved Hide resolved
src/tests/stdlib/make_executable.ab Outdated Show resolved Hide resolved
@Mte90
Update make_executable.ab
689c602 
keep consistency
@Mte90 Mte90 requested a review from hdwalters October 3, 2024 10:36
@Ph0enixKM Ph0enixKM added this to the Amber 0.4.0-alpha milestone Oct 3, 2024
@Ph0enixKM Ph0enixKM removed this from the Amber 0.4.0-alpha milestone Oct 3, 2024
@Mte90 Mte90 merged commit cd0338a into master Oct 4, 2024
1 check passed
@Mte90 Mte90 deleted the 296-feature-change-unsafe-keyword-to-trust branch October 4, 2024 08:07
@Mte90 Mte90 mentioned this pull request Oct 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mte90 Mte90 Mte90 approved these changes

@hdwalters hdwalters hdwalters approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Change unsafe keyword to trust
3 participants
@Ph0enixKM @Mte90 @hdwalters