Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Update grammar.ebnf #608 #609

Merged
merged 12 commits into from
Nov 25, 2024
Merged

[BUG] Update grammar.ebnf #608 #609

merged 12 commits into from
Nov 25, 2024

Conversation

Ph0enixKM
Copy link
Member

@Ph0enixKM Ph0enixKM commented Nov 22, 2024

This file exists so that external developers can easily create plugins interpreting Amber's syntax (syntax highlighting etc.). This file provides necessary information of how the syntax is being parsed from the more abstract (high level) point of view.

@Ph0enixKM Ph0enixKM linked an issue Nov 22, 2024 that may be closed by this pull request
@hdwalters
Copy link
Contributor

hdwalters commented Nov 23, 2024

Also consider either (i) adding these keywords already supported in the Vim plugin, (ii) advising me which ones to remove from the Vim plugin, or (iii) marking them as from older versions of Amber, and hard-coding (e.g. unsafe) in the Amber script you proposed:

break
continue
fail
is
ref
return
status
unsafe

@Ph0enixKM
Copy link
Member Author

@hdwalters updated

@hdwalters
Copy link
Contributor

It might also be helpful to (i) make the script executable, and (ii) echo the sorted keywords on separate lines:

$ amber keywords.ab 
and
as
break
cd
const
...

@Ph0enixKM
Copy link
Member Author

Concerns addressed

@Ph0enixKM
Copy link
Member Author

Done

@Mte90 Mte90 merged commit cba1671 into master Nov 25, 2024
@Mte90 Mte90 deleted the 608-bug-update-grammarebnf branch November 25, 2024 09:04
lens0021 pushed a commit to lens0021/amber that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Update grammar.ebnf
3 participants