Support Ruby 2.6 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't mind adding 2.6. I don't think there's anything in xmp that requires newer versions. I suppose we could mention in the README what nokogiri version is officially needed for each Ruby version:
|
requirements for Ruby versions
|
@wpiekutowski does this seem sufficient? I'd be happy to have another release with this and #9. |
wpiekutowski
approved these changes
Sep 14, 2024
|
Thanks, looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current macOS (14, Sonoma) ships with Ruby 2.6.10. Current xmp works with that version of Ruby without any changes, so let's continue supporting that version of Ruby for now, so that programs which use xmp can run on macOS without installing Ruby.
macOS's copy of Ruby is deprecated, so we should only support Ruby 2.6 as long as it doesn't hold back xmp.
The nokogiri in Gemfile.lock requires Ruby 2.7, so anyone developing xmp on Ruby 2.6 will need to
bundle update nokogiri. I don't think this PR should change Gemfile.lock, which would pin all developers to an old nokogiri (1.13).I don't know whether Travis can build xmp on Ruby 2.6 given that Gemfile.lock requires Ruby 2.7. If it can't, and there isn't an easy fix, I'd withdraw this PR.