Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve new app creation experience #1302

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,7 @@ lib/
/tmp
shard.lock
package-lock.json
node_modules
node_modules
/myapp
cli
cli.dwarf
2 changes: 1 addition & 1 deletion shard.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: amber

version: 1.3.1
version: 1.3.2

authors:
- Amber Team and Contributors <amberframework.org>
Expand Down
2 changes: 1 addition & 1 deletion spec/support/helpers/cli_helper.cr
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ module CLIHelper
def expected_db_url(db_key, env)
case db_key
when "pg"
"postgres://postgres:password@localhost:5432/#{TEST_APP_NAME}_#{env}"
"postgres://#{`whoami`.strip("\n")}:@localhost:5432/#{TEST_APP_NAME}_#{env}"
when "mysql"
"#{db_key}://root@localhost:3306/#{TEST_APP_NAME}_#{env}"
else
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ redis_url: "redis://localhost:6379"
when "mysql" -%>
database_url: mysql://root@localhost:3306/<%= database_name %>_development
<% when "pg" -%>
database_url: postgres://postgres:password@localhost:5432/<%= database_name %>_development
database_url: postgres://<%= `whoami`.strip("\n") -%>:@localhost:5432/<%= database_name %>_development
<% when "sqlite" -%>
database_url: sqlite3:./db/<%= database_name %>_development.db
<% else
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ redis_url: "redis://localhost:6379"
when "mysql" -%>
database_url: mysql://root@localhost:3306/<%= database_name %>
<% when "pg" -%>
database_url: postgres://postgres:password@localhost:5432/<%= database_name %>
database_url: postgres://<%= `whoami`.strip("\n") %>:@localhost:5432/<%= database_name %>
<% when "sqlite" -%>
database_url: sqlite3:./db/<%= database_name %>.db
<% else
Expand Down
2 changes: 1 addition & 1 deletion src/amber/version.cr
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module Amber
VERSION = "1.3.1"
VERSION = "1.3.2"
end