-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new exception page #864
Conversation
…er into fa/new-exception-page
current error page specs by @marksiemers already cover this 👍 |
@faustinoaq Just finished up extracting this to a shared lib: https://github.com/crystal-loot/exception_page You should be able to use it here. I removed the "watcher" stuff since it isn't always needed, but you can hook into the provided methods for customizing the buttons and the javascript that are in the README. Feel free to open PRs for stuff you need in case it doesn't cover everything! |
@paulcsmith Thanks you so much! Your shard looks very very nice, I gonna use it here now 👍 |
Lucky already has an exception page base leveraging on this code and Amber yet does not this is a bummer :( |
@eliasjpr Yeah. no problem 😅 The new |
@faustinoaq given the recent migration of a lot of this code to crystal community repo, should this be closed or merged? |
@faustinoaq I agree to use the new shard instead you can close this PR and open a new one implementing the shard. |
Description of the Change
This PR adds a new exception page based on Phoenix one, see: phoenixframework/phoenix#1776
This PR will be required by next
amber watch
PRsAlternate Designs
Keep basic error pages
Benefits
Possible Drawbacks
[x] Reload (watch) checkbox depends on new
amber watch
configuration (based onamber_reload.js
without reload pipe)