added reload pipe and specs back #960
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Adds back reload pipe. This was a useful feature although it wasn't perfect. Injecting the JS at the beginning of the response had some issues and messed up styles sometimes, as @faustinoaq pointed out in #865 and @samholst pointed out in #959.
This should be addressed. Hopefully we can finish the
configurable watchPR that @faustinoaq started soon. Although @samholst's is more of a single issue fix.My recommendation would be to merge this back in and then work on improving it. @drujensen had talked about working on configurable watch.