Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid empty case statement #124

Merged
merged 3 commits into from
Jan 27, 2018
Merged

avoid empty case statement #124

merged 3 commits into from
Jan 27, 2018

Conversation

drujensen
Copy link
Member

fix issue #112

@drujensen drujensen requested review from eliasjpr and a team January 27, 2018 11:07
robacarp
robacarp approved these changes Jan 27, 2018
View reviewed changes
Copy link
Member

@robacarp robacarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, thanks. Can you add a field less model to the specs too?

@drujensen drujensen force-pushed the dj/fix-empty-field-mapping branch from 6104cc7 to eafb379 Compare January 27, 2018 16:54
@drujensen drujensen merged commit 72e165e into master Jan 27, 2018
@drujensen drujensen deleted the dj/fix-empty-field-mapping branch January 27, 2018 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faustinoaq faustinoaq faustinoaq approved these changes

@eliasjpr eliasjpr eliasjpr approved these changes

@robacarp robacarp robacarp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drujensen @robacarp @eliasjpr @faustinoaq