refactor: Unify pk and content and timestamps into FIELDS
#169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In master, when we want to iterate all fields, we have to process three kinds of fields pk, content columns and timestamps as following code. I feel this is a boring work and the code looks difficult.
This PR merges them into one FIELDS, and the
primary
andtimestamp
now becomes just wrapper macros to thefield
. Thus, we can simply iterateFIELDS
to scan all fields.related refactor (Granite::ORM::Base)
CONTENT_FIELDS
that removes PK fromFIELDS
Base.fields
to provide cached field names.Base.content_fields
to provide cached content field names.Base#params
toBase#content_values
for clarityBest regards,