Fixes to Migrator provided by Maiha #201
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dry up codes about creating tables in specs, and put it production code as
Granite::ORM.migrator
.This helps users
implementation
Granite::Adapter::Base::Schema::Types
Granite::Adapter::Mysql::Schema::Types
I just defined rules about basic classes used in current specs.
Bool
,Float32
,Float64
,Int32
,Int64
,String
,Time
If
migrator
is exected with undefined types, it raises a runtime error as below.Best regards,