Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: querybuilder logger #224

Merged
merged 1 commit into from
Jun 9, 2018
Merged

bugfix: querybuilder logger #224

merged 1 commit into from
Jun 9, 2018

Conversation

robacarp
Copy link
Member

@robacarp robacarp commented Jun 8, 2018

The querybuilder as is doesn't work and isn't usable because the logger call isn't working, resulting in this error message:

in lib/granite/src/granite/query/executors/base.cr:8: undefined constant Granite::Logger

      Granite::Logger.log messages
      ^~~~~~~~~~~~~~~

This corrects the showstopping bug, and lets this appear in the logs instead:

amber watch 2018-06-08 15-18-18

The log formatting still needs a bit of work, but at least it compiles

🍌

@robacarp robacarp merged commit 7661430 into master Jun 9, 2018
@robacarp robacarp deleted the query_logger_bugfix branch June 9, 2018 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants