Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update database docker #241

Merged
merged 4 commits into from
Jun 27, 2018
Merged

Update database docker #241

merged 4 commits into from
Jun 27, 2018

Conversation

Thellior
Copy link
Contributor

What is done

  • Changed mysql version from 5.6 to 5.7 (8.0 gives an error)
  • Changed postgres version from 9.5 to 10.4

@robacarp
Copy link
Member

That’s a big upgrade for Postgres. I doubt we are doing anything that PG changed during the upgrades, but I wonder if we should start to consider testing Granite against multiple versions of the databases?

@Thellior
Copy link
Contributor Author

@robacarp I think that it's a great idea. I'm going to read some documents about how it's best achieved with dockers and i will come with my idea that we can approve :)

@Blacksmoke16
Copy link
Contributor

Blacksmoke16 commented Jun 23, 2018

should just have to add another service to the docker-compose.

for example:

  pg-10.4:
    image: postgres:10.4
  pg-9.5:
    image: postgres:9.5
  mysq-5.6:
    image: mysql:5.6
    environment:
      MYSQL_ROOT_PASSWORD: pass
      MYSQL_DATABASE: test
      MYSQL_USER: user
      MYSQL_PASSWORD: pass
  mysql-5.7:
    image: mysql:5.7
    environment:
      MYSQL_ROOT_PASSWORD: pass
      MYSQL_DATABASE: test
      MYSQL_USER: user
      MYSQL_PASSWORD: pass

EDIT: Also could use a .env file to share config between containers. https://docs.docker.com/compose/environment-variables/#the-env_file-configuration-option

@robacarp robacarp merged commit 6407b52 into amberframework:master Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants