Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix conflicting use of query #247

Merged
merged 4 commits into from
Jul 17, 2018
Merged

fix conflicting use of query #247

merged 4 commits into from
Jul 17, 2018

Conversation

drujensen
Copy link
Member

@drujensen drujensen commented Jun 27, 2018 •
edited
Loading

renamed the macro to select_statement so it won't conflict with the pass-through query method. fixed #246

@drujensen drujensen requested review from damianham, robacarp, faustinoaq and a team June 27, 2018 02:35
@drujensen drujensen mentioned this pull request Jun 27, 2018
Closed
damianham
damianham suggested changes Jun 27, 2018
View reviewed changes
Copy link
Contributor

@damianham damianham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be worthwhile adding something to the test suite to ensure Model.query("select fields from table") isn't broken by any future update

@drujensen
Copy link
Member Author

@damianham 👍 right. I will add one for each pass-through.

robacarp
robacarp reviewed Jun 27, 2018
View reviewed changes
Copy link
Member

@robacarp robacarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 when there's a test too!

@drujensen
Copy link
Member Author

@damianham @robacarp added tests for the passthroughs.

@drujensen drujensen merged commit d6a758b into master Jul 17, 2018
@drujensen drujensen deleted the dj/rename-query-to-select-statement branch July 17, 2018 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damianham damianham damianham requested changes

@robacarp robacarp robacarp approved these changes

@faustinoaq faustinoaq Awaiting requested review from faustinoaq

Assignees
No one assigned
Labels
kind:breaking-change pr:needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unable to run an arbitrary query
3 participants
@drujensen @damianham @robacarp