Dj/271 maintain one database connection #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robacarp
approved these changes
Aug 27, 2018
| @@ -16,7 +16,7 @@ describe Granite::Adapters do | |||
|
|
|||
| it "should disallow multiple adapters with the same name" do | |||
| expect_raises(Exception, "Adapter with name 'mysql' has already been registered.") do | |||
| Granite::Adapters << Granite::Adapter::Pg.new({name: "mysql", url: "PG_DATABASE_URL"}) | |||
| Granite::Adapters << Granite::Adapter::Pg.new({name: "mysql", url: ENV["PG_DATABASE_URL"]}) | |||
There was a problem hiding this comment.
this probably doesn't matter, the test is expecting to catch an exception before the url is ever acted on
| end | ||
|
|
||
| def open(&block) | ||
| yield DB.open(@url) | ||
| yield database |
|
@robacarp FYI I've submitted PR to TFB to update Crystal and frameworks to the latest version TechEmpower/FrameworkBenchmarks#4020 The tests are passing now, but I think I should maybe wait for this fix in Granite ORM for better benchmarks results for Amber? Let me know if there is a bugfix release for Granite ORM planned soon, so I can update my PR before it gets merged in. |
|
@vlazar I will release this today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the connection issue #271