Association improvements #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bang versions
drujensen
approved these changes
Nov 22, 2018
| primary courier_id : Int32, auto: false | ||
| field! issuer_id : Int32 | ||
|
|
||
| belongs_to service : CourierService, primary_key: "owner_id" |
There was a problem hiding this comment.
@Blacksmoke16 just to confirm, can you use a Symbol instead of a String for the value?
belongs_to service : CourierService, primary_key: :owner_idThere was a problem hiding this comment.
Looks like mysql is failing. :-(
There was a problem hiding this comment.
Yea, ill take a look.
Should be able to, just sets it and calls .id on them.
There was a problem hiding this comment.
@drujensen I figured it out, see 2e80d10.
I guess no other spec had it setup like I did this one time. 🤷♂️
EDIT: And yea, symbol primary_key: values works 👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
belongs_toandhas_oneassociations.belongs_toandhas_oneassociations.has_manyassociation use whatever primary key is defined on the model, vs always assumingid