Support array IN queries with query builder #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliasjpr
reviewed
Jan 6, 2019
| @@ -23,6 +23,16 @@ require "../spec_helper" | |||
| assembler.where | |||
| assembler.numbered_parameters.should eq ["bob", "23"] | |||
| end | |||
|
|
|||
| it "property defines IN query" do | |||
There was a problem hiding this comment.
In the case of Ints, Floats and bools would it have single quotes? I ask because I don't see tests for those cases.
There was a problem hiding this comment.
Ah crap. No they wouldn't. I'll get that fixed up.
There was a problem hiding this comment.
@eliasjpr Fixed. This did expose an issue with Float32 types. I'll look into it later and make a separate PR for that. Not sure if its a Granite issue or DB/adapter shard issue yet.
Fix env var for PG tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for the query builder to handle params that are arrays. It auto casts them to an
:inquery.I had some trouble using placeholder vars in this context. Both
["('outstanding','in_progress')"]and[["outstanding", "in_progress"]]caused a syntax error. To get around this i just build out the IN statement and plop in the value into the query. Any ideas on how to better handle this?