Make Granite::Base abstract #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add volume to docker-compose
|
Apparently the volume breaks CI. 🤷♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add volume to docker-compose
Bumps crystal version in dockerfile (to get specs to pass)
Since
Granite::Basewill never be instantiated on its own it should be abstract. This will prevent crystal-lang/crystal#7473 from happening when having multiple possible models as a return type.Also adds a volume to the
docker-composefile so that you wont have to rebuild thespeccontainer after making changes for those changes to be reflected when runningspec.