Make primary_type return the class type vs string #325
+17
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robacarp
reviewed
Feb 25, 2019
| @@ -44,7 +44,7 @@ module Granite::Table | |||
| @@table_name = "{{table_name}}" | |||
| @@primary_name = "{{primary_name}}" | |||
| @@primary_auto = "{{primary_auto}}" | |||
| @@primary_type = "{{primary_type}}" | |||
| @@primary_type = {{primary_type}} | |||
There was a problem hiding this comment.
I'm okay with this, and I agree it is a better paradigm. It is also a breaking change to the API.
There was a problem hiding this comment.
We could add a new method to get the actual type and leave the string one untouched if we wanted to avoid the breaking change. However, I'm skeptical if it would be worth it?
There was a problem hiding this comment.
I have no problem incrementing the version, just want to me sure it's marked as a pull which is a breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the
primary_typemethod return the actual.classtype of the primary key, versus a string. Having the actual type is much more useful.