Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some updates for Crystal 0.28.0 #330

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Some updates for Crystal 0.28.0 #330

merged 1 commit into from
Apr 26, 2019

Conversation

Blacksmoke16
Copy link
Contributor

  • Updates Dockerfile to 0.28.0 for CI
  • Updates deprecated references of Time.utc_now and Time.now (Crystal 0.28.0 support #329)
  • Updates docker-compose file to show all deprecation warnings
    • Also will error on something being deprecated. I could go either way if we want CI to fail or not if something becomes deprecated. Thoughts @drujensen @robacarp @amberframework/granite?

robacarp
robacarp approved these changes Apr 22, 2019
View reviewed changes
Copy link
Member

@robacarp robacarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Blacksmoke16 !

@robacarp
Copy link
Member

@Blacksmoke16 failing CI on deprecated makes sense... it can be rolled back later if needed, but it's good to know as early as possible about that sort of thing

@robacarp robacarp merged commit 70afa14 into amberframework:master Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robacarp robacarp robacarp approved these changes

Assignees
No one assigned
Labels
pr:needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Blacksmoke16 @robacarp