Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow union types #341

Merged
merged 1 commit into from
Jul 3, 2019

Conversation

Blacksmoke16
Copy link
Contributor

@Blacksmoke16 Blacksmoke16 commented Jun 10, 2019

Resolves #340

...
in spec/spec_helper.cr:16: while requiring "./spec_models"

require "./spec_models"
^

in spec/spec_models.cr:8: The type of Teacher#id cannot be a Union.  The 'primary' macro declares the type as nilable by default.

{% begin %}
^
...
in spec/spec_helper.cr:16: while requiring "./spec_models"

require "./spec_models"
^

in spec/spec_models.cr:8: The type of Teacher#age cannot be a Union.  The 'field' macro declares they type as nilable by default.  Use the 'field!' macro to declare a not nilable field.

{% begin %}

@drujensen drujensen merged commit bc68440 into amberframework:master Jul 3, 2019
@Blacksmoke16 Blacksmoke16 deleted the disallow-unions branch July 3, 2019 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error undefined macro method 'Union#resolve'
3 participants