Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix read_attribute, see #396 #397

Merged
merged 2 commits into from
May 5, 2020
Merged

Fix read_attribute, see #396 #397

merged 2 commits into from
May 5, 2020

Conversation

msa7
Copy link
Contributor

@msa7 msa7 commented May 4, 2020 •
edited by Blacksmoke16
Loading

Fixes #396

@Blacksmoke16
Copy link
Contributor

Nice! Maybe add a spec to ensure this doesn't regress?

@drujensen
Copy link
Member

@msa7 will you be able to add a spec? if not, maybe someone can pick up the mantel and get this over the finish line.

@msa7
Copy link
Contributor Author

msa7 commented May 5, 2020

@drujensen I will do specs

@msa7
Copy link
Contributor Author

msa7 commented May 5, 2020

I hope the spec is enough

@drujensen drujensen removed the pr:wip label May 5, 2020
@drujensen drujensen merged commit 1daaa35 into amberframework:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blacksmoke16 Blacksmoke16 Blacksmoke16 approved these changes

Assignees
No one assigned
Labels
kind:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Read_attribute does not work when column is array
3 participants
@msa7 @Blacksmoke16 @drujensen