Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Crystal 0.25.0 JSON::Any API #32

Merged
merged 1 commit into from
Jun 15, 2018

Conversation

bcardiff
Copy link
Contributor

This PR update the code to the future crystal 0.25 version regarding JSON::Any API.

Ref: crystal-lang/crystal#5183

@docelic
Copy link
Collaborator

docelic commented May 28, 2018

Hey @bcardiff awesome, thanks! What are your instructions for merging this? I see it does not work on 0.24.2, and 0.25 is not listed yet on https://github.com/crystal-lang/crystal/releases.

Do you suggest that this gets merged after 0.25 is released, and that we effectively start requiring 0.25 as minimum version after that?

@bcardiff
Copy link
Contributor Author

Hi @docelic, it's up to you if you want to try to keep compatibility with 0.24.2, but that will requiere some ifdef/responds_to checks in the code.

My suggestion would be to wait for merging until 0.25 is ready (last days where checking that the ecosystem is mostly ready for it without many issues, from that check this PR emerged :-) ). After 0.25 is release I would suggest a new release changing the minor version. Later and only if needed, a patch version can be released with backported features and 0.24.2 support.

@docelic
Copy link
Collaborator

docelic commented May 28, 2018

We'll do so, thanks!

@faustinoaq
Copy link

Fixes #33 Thank you @bcardiff !

@docelic docelic merged commit 70f5db7 into amberframework:master Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants