# frozen string literal: true #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grosser
reviewed
Apr 17, 2018
lib/recaptcha/client_helper.rb
Outdated
| @@ -57,9 +61,9 @@ def invisible_recaptcha_tags(options = {}) | |||
| end | |||
|
|
|||
| def self.recaptcha_components(options = {}) | |||
| html = "" | |||
| html = StringIO.new | |||
grosser
reviewed
Apr 17, 2018
.rubocop.yml
Outdated
| Include: | ||
| - 'Rakefile' | ||
| - 'Gemfile' | ||
| - 'Rakefile' | ||
| Exclude: | ||
| - 'vendor/**/*' | ||
| - 'demo/**/*' | ||
| - 'test/**/*' |
There was a problem hiding this comment.
prefer test exclude for only frozen strings formatting, since sanity checks should still run in test folder
grosser
reviewed
Apr 17, 2018
| module Recaptcha | ||
| VERSION = "4.8.0".freeze | ||
| VERSION = '4.8.0' |
There was a problem hiding this comment.
FYI this makes it un-frozen on <2.3 ... but does not matter much
replaced StringIO by ''.dup
|
FYI pushed an update to rubocop to display by default and move |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
# frozen_string_literal: truemagic comment for ruby 2.3 and higher