feat: added project ci #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge both
Features
Bug Fixes
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
feat: added project ci
ivelin
reviewed
Mar 7, 2021
| This repo hosts [Netlify functions](https://www.netlify.com/products/functions/) that handle Ambianic premium user subscriptions. This is code that cannot run in the browser PWA, because it needs access keys to subscription and payment gateway services (Stripe) shared between all app users. If the code runs in the PWA, users will be able to see and manipulate each other's premium subscription data. | ||
| This repo hosts [Netlify functions](https://www.netlify.com/products/functions/) that handle Ambianic premium user subscriptions. This is code that cannot run in the browser PWA, because it needs access keys to subscription and payment gateway services (Stripe) shared between all app users. If the code runs in the PWA, users will be able to see and manipulate each other's premium subscription data | ||
|
|
||
| A high level prototype of how these functions make up the ambianic serverless feature can be found [here](https://drive.google.com/file/d/181etJhBye0u1zvqzAnBY0VtCS0A3SlQ-/view?usp=sharing). |
There was a problem hiding this comment.
@vickywane in the diagram towards the bottom it shows Edge Calls Google API, I think the intention is to show that Edge calls Ambianic Notification Service APIs.
ivelin
approved these changes
Mar 7, 2021
There was a problem hiding this comment.
@vickywane I think this is a good first step. Merging and opening separately a few follow up issues.
ivelin
pushed a commit
that referenced
this pull request
Jun 2, 2021
* feat: project CI * feat: corrected docs and added architecture diagram to readme * feat: project CI * update: added code coverage report * update: added code coverage report * update: updated function to use local netlify server * update: updated function to use local netlify server * fix: moved stripe key to secrets && improved scripts * fix: update * fix: update Co-authored-by: Ivelin Ivanov <ivelin@ambianic.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.