Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighthouse minified-css check is breaking accross all CI build #671

Closed
vickywane opened this issue Jul 12, 2021 · 1 comment
Closed

Lighthouse minified-css check is breaking accross all CI build #671

vickywane opened this issue Jul 12, 2021 · 1 comment
Assignees

Comments

@vickywane
Copy link
Contributor

vickywane commented Jul 12, 2021

Describe the bug
The minified-CSS check performed within the Lighthouse job in the Ambianic-PWA pipeline is breaking across all CI builds. CSS Minification is something that should be automatically performed when a production bundle of this application is created.

The culprit causing this break seems to be Vuetify as it the primary component library used in this project. It was last upgraded in this pull request to version 2.5.6 .

To Reproduce
Steps to reproduce the behavior:

  1. Clone this repository and create a pull request to trigger the CI build containing the Lighthouse checks.

Expected behavior
All styling within the application should be automatically minified when a production bundle of the application is created.

Steps To Fix

  1. Clone this repository and downgrade Vuetify to its previous version in a different branch.
  2. Create a pull request from the new branch to trigger the CI build containing the Lighthouse checks, and watch if the minified-CSS checks pass or fail.

Cc: @ivelin

@vickywane
Copy link
Contributor Author

Closing this issue as the minified-css check has been fixed.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant