- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix lighthouse minified-css check #672
Conversation
Bug Fixes
Update
Features
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
This pull request introduces 1 alert when merging 5fe9e3d into 7d7672f - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #672 +/- ##
==========================================
+ Coverage 81.56% 82.68% +1.11%
==========================================
Files 35 35
Lines 971 1022 +51
Branches 84 88 +4
==========================================
+ Hits 792 845 +53
+ Misses 179 177 -2
|
5fe9e3d
to
ad9106a
Compare
This pull request introduces 1 alert when merging 43619b9 into 7d7672f - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging c3c095e into 7d7672f - view on LGTM.com new alerts:
|
@vickywane Did you have a chance to explore some of the build time CSS minimization techniques? The Lighthouse error seems to be related to the large custom meterial design icons CSS that we started pulling in recently. See these techniques and related discussions: vuetifyjs/vuetify#7265 |
I am currently suspending this pull request as the lighthouse checks resumed passing in the latest commits against other branches. It however seems the failure came from external dependencies within this project which has been fixed in the latest updates from the library authors. I will however re-open this pull request if we run into this issue again. |
This pull request will fix this issue, tracking the current failure of the
minified-css
checks with the Ambianic CI build.This pull request will either upgrade or downgrade the Vuetify package version to know which version is failing the lighthouse check.