Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix lighthouse minified-css check #672

Closed
wants to merge 12 commits into from

Conversation

vickywane
Copy link
Contributor

@vickywane vickywane commented Jul 12, 2021

This pull request will fix this issue, tracking the current failure of the minified-css checks with the Ambianic CI build.

This pull request will either upgrade or downgrade the Vuetify package version to know which version is failing the lighthouse check.

@gitpod-io
Copy link

gitpod-io bot commented Jul 12, 2021

@commit-lint
Copy link
Contributor

commit-lint bot commented Jul 12, 2021

Bug Fixes

Update

Features

  • updated vuetify version (ad9106a)

Contributors

vickywane

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@lgtm-com
Copy link

lgtm-com bot commented Jul 12, 2021

This pull request introduces 1 alert when merging 5fe9e3d into 7d7672f - view on LGTM.com

new alerts:

  • 1 for Property access on null or undefined

@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #672 (c3c095e) into master (7d7672f) will increase coverage by 1.11%.
The diff coverage is 94.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #672      +/-   ##
==========================================
+ Coverage   81.56%   82.68%   +1.11%     
==========================================
  Files          35       35              
  Lines         971     1022      +51     
  Branches       84       88       +4     
==========================================
+ Hits          792      845      +53     
+ Misses        179      177       -2     
Impacted Files Coverage Δ
src/components/shared/ListItem.vue 100.00% <ø> (ø)
src/main.js 100.00% <ø> (ø)
src/views/Home.vue 100.00% <ø> (ø)
src/views/Timeline.vue 30.07% <ø> (+4.51%) ⬆️
src/views/About.vue 85.71% <84.21%> (-14.29%) ⬇️
cypress/integration/ambianic-tests/about.spec.js 100.00% <100.00%> (ø)
...ypress/integration/ambianic-tests/settings.spec.js 100.00% <100.00%> (ø)
src/remote/edgeAPI.js 100.00% <100.00%> (ø)
src/store/action-types.js 100.00% <100.00%> (ø)
src/store/index.js 81.81% <100.00%> (+21.81%) ⬆️
... and 4 more

@vickywane vickywane changed the title Fix/lighthouse check ci: fix lighthouse minified-css check Jul 12, 2021
@vickywane vickywane force-pushed the fix/lighthouse-check branch from 5fe9e3d to ad9106a Compare July 12, 2021 15:37
@lgtm-com
Copy link

lgtm-com bot commented Jul 12, 2021

This pull request introduces 1 alert when merging 43619b9 into 7d7672f - view on LGTM.com

new alerts:

  • 1 for Property access on null or undefined

@lgtm-com
Copy link

lgtm-com bot commented Jul 12, 2021

This pull request introduces 1 alert when merging c3c095e into 7d7672f - view on LGTM.com

new alerts:

  • 1 for Property access on null or undefined

@ivelin
Copy link
Contributor

ivelin commented Jul 21, 2021

@vickywane Did you have a chance to explore some of the build time CSS minimization techniques? The Lighthouse error seems to be related to the large custom meterial design icons CSS that we started pulling in recently. See these techniques and related discussions:

vuetifyjs/vuetify#7265
https://www.gitmemory.com/issue/vuetifyjs/vuetify/7265/719335112
https://blog.logrocket.com/the-complete-best-practices-for-minifying-css/
https://web.dev/minify-css/
https://vuetifyjs.com/en/features/theme/
https://github.com/bentatum/minify-css-string

@vickywane
Copy link
Contributor Author

I am currently suspending this pull request as the lighthouse checks resumed passing in the latest commits against other branches.

It however seems the failure came from external dependencies within this project which has been fixed in the latest updates from the library authors.

I will however re-open this pull request if we run into this issue again.

@vickywane vickywane closed this Aug 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lighthouse minified-css check is breaking accross all CI build
2 participants