fix: dataconnection _buffer use javascript syntax #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sense. Thank you! These look like errors while porting from the JS original. Would you be interested in submitting a regression test so we can begin improving stability as new code comes in? |
Hello! Yes, I would be happy to help. But I am very busy at the moment, in the second half of June I could come back. |
|
Awesome! Thank you so much. Will keep an eye out for the test case.
…On Wed, May 24, 2023 at 7:08 AM Multu ***@***.***> wrote:
Would you be interested in submitting a regression test so we can begin
improving stability as new code comes in?
Hello! Yes, I would be happy to help. But I am very busy at the moment, in
the second half of June I could come back.
—
Reply to this email directly, view it on GitHub
<#63 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARBUFOLIQ7EYPYZPKM4YPLXHX22XANCNFSM6AAAAAAYKUH3MY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors pop up because non-Python functions and attributes are used