Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move logic to render HTML and text content to dedicated methods, fixing #21. #22

Merged
merged 4 commits into from
Nov 15, 2024

Conversation

KommuSoft
Copy link
Contributor

No description provided.

Copy link
Contributor

@GitRon GitRon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KommuSoft Thx for your input! That's really a good improvement. What do you say to my suggestions?

django_pony_express/services/base.py Outdated Show resolved Hide resolved
django_pony_express/services/base.py Outdated Show resolved Hide resolved
django_pony_express/services/base.py Outdated Show resolved Hide resolved
Copy link
Contributor

@GitRon GitRon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌 Thx for your effort!

@GitRon
Copy link
Contributor

GitRon commented Nov 15, 2024

@KommuSoft There's a linting issue. Would you mind running pre-commit locally?

pre-commit run --all-files --hook-stage push

Copy link
Contributor

@GitRon GitRon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting

Copy link
Contributor

@GitRon GitRon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@GitRon GitRon merged commit 8c93bda into ambient-innovation:master Nov 15, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants