Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wifi] remove unregister of wifi event #190

Merged
merged 1 commit into from
Apr 8, 2024
Merged

[wifi] remove unregister of wifi event #190

merged 1 commit into from
Apr 8, 2024

Conversation

xshuqun
Copy link
Collaborator

@xshuqun xshuqun commented Apr 3, 2024

  • Remove unregistering of wifi event as it will affect next retry connection by driver.

Notes:

  • When driver retries, it does not enter from wifi_connect again, so wifi event will not be re-registered if un-registered in wifi_disconn_hdl. This will cause the next connection to timeout as Semaphore is unable to release

@xshuqun
[wifi] remove unregister of wifi event
fd3a8a6 
* Remove unregistering of wifi event as it will affect next retry connection by driver.

Notes:
* When driver retries, it does not enter from wifi_connect again, so wifi event will not be re-registered if un-registered in wifi_disconn_hdl. This will cause the next connection to timeout as Semaphore is unable to release
@SirRu24 SirRu24 merged commit e292d37 into main Apr 8, 2024
1 check passed
@SirRu24 SirRu24 deleted the wifi_event_handler branch April 8, 2024 01:43
xshuqun added a commit that referenced this pull request Apr 22, 2024
@xshuqun
[wifi] remove unregister of wifi event (#190)
b194e20 
* Remove unregistering of wifi event as it will affect next retry connection by driver.

Notes:
* When driver retries, it does not enter from wifi_connect again, so wifi event will not be re-registered if un-registered in wifi_disconn_hdl. This will cause the next connection to timeout as Semaphore is unable to release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SandyYeow SandyYeow SandyYeow approved these changes

@SirRu24 SirRu24 SirRu24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xshuqun @SandyYeow @SirRu24