[sdk] matter restructure #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
xshuqun
commented
Apr 25, 2024
xshuqun
commented
- Change CHIP_PROJECT to CONFIG_MATTER for matter changes.
- CHIP_PROJECT is needed for building connectedhomeip files.
- CONFIG_MATTER is needed for building ameba files.
- Add CONFIG_BT macro into makefile
- Add header files for configuration
- rename mbedtls-matter to mbedtls-2.28.1
* Change CHIP_PROJECT to CONFIG_MATTER for matter changes. * CHIP_PROJECT is needed for building connectedhomeip files. * CONFIG_MATTER is needed for building ameba files. * Add CONFIG_BT macro into makefile * Add header files for configuration * rename mbedtls-matter to mbedtls-2.28.1
* remove other platfrom config
SandyYeow
reviewed
Apr 25, 2024
There was a problem hiding this comment.
- dct.h removed const in header. As per discussed, we will maintain this but need to check back Hank's changes in header but not in source file.
- some make file indentation are not align from the review (eg: AMEBAZ2_TOOLDIR & MATTER_MAKEDIR in component/common/application/matter/project/amebaz2/make/refrigerator/lib_chip_refrigerator_main.mk). May be can recheck on the makefile whether they are not align or just github showing differently.
SandyYeow
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.