Skip to content

Conversation

@amd-xiaoyu12
Copy link
Owner

@amd-xiaoyu12 amd-xiaoyu12 commented May 20, 2025

Simplify the condition check, since DTensor is also a Tensor:
if isinstance(tensor, torch.Tensor) or isinstance(tensor, DTensor): =>
if isinstance(tensor, torch.Tensor):

The logic for DTensor export later within this function will handle it.

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Simplify the condition check, since DTensor is also a Tensor
if isinstance(tensor, torch.Tensor) or isinstance(tensor, DTensor):
=>
if isinstance(tensor, torch.Tensor):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants