Skip to content

Conversation

@kurtis-b-1
Copy link
Collaborator

@kurtis-b-1 kurtis-b-1 commented Nov 14, 2025

Address #15.

Added

  • Using task groups in the inner-most loop of MHA runtime. Without it, a long list of BD errors shows up. Checking with previous CI results, this change doesn't seem to negatively affect the performance of MHA.

Changed

  • Use same task groups for fill operations as the drain operations in operators such as AXPY, etc.

PR Merge Checklist

  1. The PR is rebased on the latest devel commit and pointing to devel.
  2. Your PR has been reviewed and approved.
  3. All checks are passing.

@andrej andrej self-requested a review November 14, 2025 18:13
Copy link
Collaborator

@andrej andrej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this so quickly

@andrej andrej merged commit 003b49d into amd:devel Nov 14, 2025
2 checks passed
@kurtis-b-1 kurtis-b-1 deleted the kurtis-b-1/fix-taskgroup-mixing branch November 17, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants