Metrics support enhancements: 1) Splitting up amd_gpu_memory_use_perc… #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent into two separate metrics: amd_gpu_memory_used and amd_gpu_memory_total. 2) Adding 'gpu' label which is the index of the gpu on the node. 3) Adding 'node' label which is the name of the node on which the gpu runs. 4) Adding pod name label.
srinivamd
suggested changes
Nov 22, 2023
| nodename, err := exec.Command("uname", "-n").Output() | ||
| if err == nil { | ||
| gNodeName = string(nodename) | ||
| gPod = string(nodename) |
There was a problem hiding this comment.
Why do we need gPod and gNodeName - what is gPod' supposed to be, is it always same as gNodeName?
| nil,// The metric's constant label dimensions. | ||
| ), | ||
| GPUMemoryUsage: prometheus.NewDesc( | ||
| GPUMemoryBusyPercent: prometheus.NewDesc( |
There was a problem hiding this comment.
By "busy" memory, does it mean "used"? Not sure what 'busy' means for memory? Could we changed to "used"?
muralimk-amd
reviewed
May 9, 2024
| @@ -141,52 +143,63 @@ func NewCollector(handle func() (collect.AMDParams)) prometheus.Collector { | |||
| GPUDevId: prometheus.NewDesc( | |||
| prometheus.BuildFQName("amd", "", "gpu_dev_id"), | |||
| "AMD Params",// The metric's help text. | |||
| []string{"gpu_dev_id", "productname"},// The metric's variable label dimensions. | |||
| []string{"gpu_dev_id", "productname", "node_id", "pod"},// The metric's variable label dimensions. | |||
There was a problem hiding this comment.
argument "pod" is not working for any of the APIs when we try to query. Please check
There was a problem hiding this comment.
Query with argument "node_id" also gives "Empty Query result"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ent into two separate metrics: amd_gpu_memory_used and amd_gpu_memory_total. 2) Adding 'gpu' label which is the index of the gpu on the node. 3) Adding 'node' label which is the name of the node on which the gpu runs. 4) Adding pod name label.