Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got
-inf
values in my target boxes, which propagated up to the loss. I tracked down this line inencode()
where a log is taken on the width/height of the boxes. For some reason, some of my data-augmented boxes have zero-width (or height).It probably happens in the data augmentation, when cropping, with boxes that are on the side of the image. One solution would be to look for zero-width/height boxes and remove them.
But I think it's a good practice to completely remove the risk of
-inf
by shifting the logarithm a tiny bit, like I do in my suggested change.What do you think?