Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SMS event not firing when no previous messages exist #34

Merged
merged 2 commits into from
May 10, 2023

Conversation

tkdrob
Copy link
Contributor

@tkdrob tkdrob commented May 8, 2023

This is an edge case where the SIM card has no texts saved the first message never gets relayed to the listeners. This PR fixes that and also avoids posting all existing texts upon startup.

Copy link
Owner

@amelchio amelchio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you. I will get a new version out within a couple of days.

@amelchio amelchio merged commit 4e2cdec into amelchio:master May 10, 2023
@tkdrob tkdrob deleted the sms_fix branch May 10, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants