touchup: set role button for diagram parts #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for velvety-vacherin-4193fb ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ameliorate-docs canceled.
|
keyserj
force-pushed
the
keyboard-clickable-diagram-parts
branch
from
5db8ad2 to
08eb1d1
Compare
regardless of context, so now you can edit text without selecting the node, and select a node in the details pane without the details indicator button. We set `cursor: pointer` to convey that a node will be selected vs `cursor: text` to convey that node's text will be selected. This seems good enough to avoid confusion, at least on desktop... We'll want to keep an eye out for if this is acceptable on mobile. also includes setting role button for diagram parts so they can be clicked by vimium.
keyserj
force-pushed
the
keyboard-clickable-diagram-parts
branch
from
08eb1d1 to
f5ee8dd
Compare
|
One idea that may be better/less-confusing is if the node type label, with it's colored & distinct background, is specifically used for the click-to-select point. Then the rest of the white background of the node can be used for clicking the input text. One downside of that though is that someone might expect clicking elsewhere on the node to select it - why just the label? Will just keep that in mind though, this seems good enough for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so they can be clicked by vimium
Description of changes
Additional context