Add ALL target for ament_generate_version_header target. #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary when using ament_generate_version_header() with a target that is an INTERFACE library, so that it actually gets built. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
sloretz
approved these changes
May 10, 2024
cottsay
approved these changes
May 10, 2024
|
Hello! Thanks for the fix. Can we also get this backported to Humble and Iron please? Thank you! |
|
CI:
|
delete-merged-branch
bot
deleted the
clalancette/add-generate-version-target-to-all
branch
|
@Mergifyio backport humble iron jazzy |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 13, 2024
This is necessary when using ament_generate_version_header() with a target that is an INTERFACE library, so that it actually gets built. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 1388e09)
mergify bot
pushed a commit
that referenced
this pull request
May 13, 2024
This is necessary when using ament_generate_version_header() with a target that is an INTERFACE library, so that it actually gets built. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 1388e09)
mergify bot
pushed a commit
that referenced
this pull request
May 13, 2024
This is necessary when using ament_generate_version_header() with a target that is an INTERFACE library, so that it actually gets built. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 1388e09)
ahcorde
pushed a commit
that referenced
this pull request
May 14, 2024
This is necessary when using ament_generate_version_header() with a target that is an INTERFACE library, so that it actually gets built. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 1388e09) Co-authored-by: Chris Lalancette <clalancette@gmail.com>
clalancette
added a commit
that referenced
this pull request
May 14, 2024
This is necessary when using ament_generate_version_header() with a target that is an INTERFACE library, so that it actually gets built. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 1388e09) Co-authored-by: Chris Lalancette <clalancette@gmail.com>
ahcorde
pushed a commit
that referenced
this pull request
May 24, 2024
This is necessary when using ament_generate_version_header() with a target that is an INTERFACE library, so that it actually gets built. Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 1388e09) Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary when using ament_generate_version_header() with a target that is an INTERFACE library, so that it actually gets built.
This should fix #525