Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare missing dependency on python3-importlib-resources #123

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

cottsay
Copy link
Contributor

@cottsay cottsay commented Jan 14, 2021

Requires ros/rosdistro#28001.

Used here:

try:
import importlib.resources as importlib_resources
except ModuleNotFoundError:
import importlib_resources

The source code supports using the importlib_resources package, but on all of the platforms we're running regular builds for, we have Python 3.7, which provides the package as part of Python itself.

@cottsay cottsay added the bug Something isn't working label Jan 14, 2021
@cottsay cottsay self-assigned this Jan 14, 2021
Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay
Copy link
Contributor Author

cottsay commented Jan 15, 2021

@ros-pull-request-builder retest this please

1 similar comment
@cottsay
Copy link
Contributor Author

cottsay commented Jan 15, 2021

@ros-pull-request-builder retest this please

@cottsay cottsay merged commit 9f3c294 into master Jan 20, 2021
@delete-merged-branch delete-merged-branch bot deleted the cottsay/importlib-resources branch January 20, 2021 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants