Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reading the package run dependencies #93

Merged
merged 1 commit into from
Oct 4, 2019

Conversation

dirk-thomas
Copy link
Contributor

Follow up of #89. Fixes reading the run dependencies which always use a semicolon / CMake list separator - independent of the platform

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas added bug Something isn't working in review Waiting for review (Kanban column) labels Oct 4, 2019
@dirk-thomas dirk-thomas self-assigned this Oct 4, 2019
@nuclearsandwich
Copy link
Contributor

If colcon is working from this same list will it need a parallel fix?

@dirk-thomas
Copy link
Contributor Author

If colcon is working from this same list will it need a parallel fix?

colcon has its own data structure. That one works otherwise we would have notices that months ago when it was changed.

@dirk-thomas dirk-thomas merged commit 339274e into master Oct 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/fix-reading-run-deps branch October 4, 2019 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in review Waiting for review (Kanban column)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants