Fix system uncrustify version detection regex #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two changes here: 1. Make the regex handle the `_d` suffix, which may or may not be present in the system's binary. 2. Disable the automatic version suffix generation on the vendored package so that our own regex can parse it. Signed-off-by: Scott K Logan <logans@cottsay.net>
clalancette
approved these changes
Mar 1, 2023
|
Blocked by ament/ament_lint#440 |
|
Closing this, as it is superseded by #37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes here:
_dsuffix, which may or may not be present in the system's binary.This may regress uncrustify tests on platforms which have newer versions of uncrustify with the
_dsuffix, where we were previously vendoring and will now see the system's version as adequate. We may need to set an upper bound on the acceptable version.This will regress our beautiful green RHEL 9 builds :(