feat(eslint): spaced comment warn instead of error #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10xLaCroixDrinker
previously approved these changes
May 11, 2020
JamesSingleton
previously approved these changes
May 12, 2020
JAdshead
previously approved these changes
May 12, 2020
PixnBits
requested changes
May 21, 2020
There was a problem hiding this comment.
could we scope this to just JSX syntax to avoid affecting ECMA Javascript code/projects?
if not the JSX syntax maybe just .jsx files would work, but we'd want to include a note about the intended scope being part of the JSX syntax and that the relaxing in the JS syntax is an undesired tradeoff for the JSX ergonomics
stevensacks
dismissed stale reviews from JAdshead, JamesSingleton, and 10xLaCroixDrinker
via
d84d33a
|
Done |
10xLaCroixDrinker
approved these changes
May 29, 2020
JamesSingleton
approved these changes
Jun 1, 2020
JAdshead
approved these changes
Jun 2, 2020
PixnBits
approved these changes
Jun 2, 2020
oneamexbot
added a commit
that referenced
this pull request
Jun 5, 2020
# [12.1.0](v12.0.3...v12.1.0) (2020-06-05) ### Features * **eslint:** spaced comment warn instead of error ([#37](#37)) ([51c539d](51c539d))
|
🎉 This PR is included in version 12.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because spaced-comment has value outside of JSX and it seems to be mainly an issue with commenting out components in JSX, which is usually a temporary state while developing, I suggest making this a warn instead of an error? Better than 'off', solves both problems, also won't block builders.