Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint): spaced comment warn instead of error #37

Merged
merged 6 commits into from
Jun 5, 2020
Merged

feat(eslint): spaced comment warn instead of error #37

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8aa8184
feat(eslint): spaced comment warn instead of error
stevensacks May 11, 2020
8f82168
Merge branch 'master' into feat/spaced-comment
JAdshead May 12, 2020
aca5f28
fix(eslint): only warn on jsx files
stevensacks May 28, 2020
d84d33a
Merge branch 'feat/spaced-comment' of https://github.com/stevensacks/…
stevensacks May 28, 2020
47ee8fd
Merge branch 'master' into feat/spaced-comment
May 29, 2020
481a8fa
Merge branch 'master' into feat/spaced-comment
Jun 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,11 @@ module.exports = {
// Disabling this rule until this is resolved https://github.com/yannickcr/eslint-plugin-react/issues/1848
// at the moment the fix makes the code look messy and at times unreadable
'react/jsx-one-expression-per-line': 'off',

// Unfortunately, the parameters for spaced-comments do not allow for JSX exclusions
// It is common to comment JSX during normal development, so 'warn' is a good compromise
// https://eslint.org/docs/rules/spaced-comment
'spaced-comment': 'warn',
},
overrides: [{
// Certain rules need to be disabled when we are linting markdown files,
Expand Down