test(integration): use a positive scenario for metric help

americanexpress · May 14, 2020 · c6d49a1 · c6d49a1
1 parent d133259
commit c6d49a1
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/__tests__/integration/one-app.spec.js b/__tests__/integration/one-app.spec.js
@@ -106,10 +106,14 @@ describe('Tests that require Docker setup', () => {
         expect.assertions(1);
         const response = await fetch(appAtTestUrls.fetchMetricsUrl);
         const parsedMetrics = parsePrometheusTextFormat(await response.text());
-        const errors = parsedMetrics
-          .filter((metric) => (!metric.help) || metric.help.length === 0)
+        const allMetricNames = parsedMetrics
           .map((metric) => metric.name);
-        expect(errors).toEqual([]);
+
+        const metricsNamesWithHelpInfo = parsedMetrics
+          .filter((metric) => metric.help && metric.help.length > 0)
+          .map((metric) => metric.name);
+
+        expect(metricsNamesWithHelpInfo).toEqual(allMetricNames);
       });
     });