Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

feat(Dockerfile): use .nvmrc to build the image #1090

Merged
merged 14 commits into from
Sep 13, 2023

Conversation

PixnBits
Copy link
Contributor

@PixnBits PixnBits commented Aug 14, 2023

Description

use .nvmrc to build the image
and run workflows, creating a single point to define the Node.js version to use and thus making upgrades easier

Motivation and Context

Avoid the myriad of locations where Node.js versions are recorded, i.e. Dockerfile and workflows. package.json engines will still need manual updates though (perhaps that can be a workflow, or a unit test to ensure it is satisfied by the contents of .nvmrc?)

How Has This Been Tested?

built locally, though not run, but did see the expected label used when manually running $ docker build . --build-arg VERSION=18.17.0 and docker build . --build-arg VERSION=$(cat .nvmrc)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch. (feat(Dockerfile): use .nvmrc to build the image (5.x.x) #1375)
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

faster Node.js version updates? this is more for the maintainers so no impact to devs is the basic requirement 😅

and run workflows, creating a single point to define the Node.js version to use
and thus making upgrades easier
@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2023

Size Change: 0 B

Total Size: 710 kB

ℹ️ View Unchanged
Filename Size
./build/app/app.js 164 kB
./build/app/app~vendors.js 411 kB
./build/app/runtime.js 7.07 kB
./build/app/service-worker-client.js 7.25 kB
./build/app/vendors.js 121 kB

compressed-size-action

@PixnBits PixnBits marked this pull request as ready for review August 14, 2023 22:22
@PixnBits PixnBits requested review from a team as code owners August 14, 2023 22:22
__tests__/package.spec.js Outdated Show resolved Hide resolved
code-forger
code-forger previously approved these changes Aug 18, 2023
@code-forger code-forger requested a review from a team August 18, 2023 09:03
Copy link
Member

@code-forger code-forger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@code-forger
Copy link
Member

This PR will look like its not building, because our settings require workflows that this PR removes.

Once this PR is ready and approved, the setting should be changed immediately before merge

JAdshead
JAdshead previously approved these changes Aug 31, 2023
.nvmrc Outdated Show resolved Hide resolved
JAdshead
JAdshead previously approved these changes Aug 31, 2023
JAdshead
JAdshead previously approved these changes Aug 31, 2023
dogpatch626
dogpatch626 previously approved these changes Sep 1, 2023
@JAdshead JAdshead dismissed code-forger’s stale review September 6, 2023 18:09

Not currently available and I believe that change has been resolved.

Dockerfile Outdated Show resolved Hide resolved
@PixnBits PixnBits dismissed stale reviews from dogpatch626 and JAdshead via 2c16533 September 8, 2023 18:59
@PixnBits PixnBits merged commit 42c562c into main Sep 13, 2023
7 checks passed
@PixnBits PixnBits deleted the feature/single-point-of-node-version branch September 13, 2023 19:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants