This repository has been archived by the owner on May 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 87
feat(Dockerfile): use .nvmrc to build the image (5.x.x) #1375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and run workflows, creating a single point to define the Node.js version to use and thus making upgrades easier
14 tasks
Size Change: 0 B Total Size: 694 kB ℹ️ View Unchanged
|
giulianok
previously approved these changes
Apr 11, 2024
should we change Lines 6 to 7 in 24dca2d
or
|
Remove 16 |
10xLaCroixDrinker
suggested changes
Apr 13, 2024
Comment on lines
-7
to
+8
"node": ">=12", | ||
"npm": ">=6" | ||
"node": "^18", | ||
"npm": "^9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your engines change is causing all workflows that run install to fail.
code-forger
approved these changes
Apr 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
use .nvmrc to build the image
and run workflows, creating a single point to define the Node.js version to use and thus making upgrades easier
Motivation and Context
Avoid the myriad of locations where Node.js versions are recorded, i.e. Dockerfile and workflows. package.json engines will still need manual updates though (perhaps that can be a workflow, or a unit test to ensure it is satisfied by the contents of
.nvmrc
?)How Has This Been Tested?
built locally, though not run, but did see the expected label used when manually running
$ docker build . --build-arg VERSION=18.17.0
anddocker build . --build-arg VERSION=$(cat .nvmrc)
Types of Changes
Checklist:
What is the Impact to Developers Using One App?
faster Node.js version updates? this is more for the maintainers so no impact to devs is the basic requirement 😅