Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

feat(Dockerfile): use .nvmrc to build the image (5.x.x) #1375

Closed
wants to merge 4 commits into from

Conversation

PixnBits
Copy link
Contributor

Description

use .nvmrc to build the image
and run workflows, creating a single point to define the Node.js version to use and thus making upgrades easier

Motivation and Context

Avoid the myriad of locations where Node.js versions are recorded, i.e. Dockerfile and workflows. package.json engines will still need manual updates though (perhaps that can be a workflow, or a unit test to ensure it is satisfied by the contents of .nvmrc?)

How Has This Been Tested?

built locally, though not run, but did see the expected label used when manually running $ docker build . --build-arg VERSION=18.17.0 and docker build . --build-arg VERSION=$(cat .nvmrc)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch. (this is that PR, see feat(Dockerfile): use .nvmrc to build the image #1090)
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

faster Node.js version updates? this is more for the maintainers so no impact to devs is the basic requirement 😅

Copy link
Contributor

Warnings
⚠️

Changes were made to package.json, but not to package-lock.json - Perhaps you need to run npm install?

Generated by 🚫 dangerJS against 24dca2d

Copy link
Contributor

Size Change: 0 B

Total Size: 694 kB

ℹ️ View Unchanged
Filename Size
./build/app/app.js 159 kB
./build/app/app~vendors.js 401 kB
./build/app/runtime.js 7.07 kB
./build/app/service-worker-client.js 7.25 kB
./build/app/vendors.js 120 kB

compressed-size-action

giulianok
giulianok previously approved these changes Apr 11, 2024
@PixnBits
Copy link
Contributor Author

should we change

one-app/package.json

Lines 6 to 7 in 24dca2d

"engines": {
"node": "^18",
to include 16.x
or
matrix:
node-version: [16.x, 18.x]
to remove 16.x ?

@10xLaCroixDrinker
Copy link
Member

should we change

one-app/package.json

Lines 6 to 7 in 24dca2d

"engines": {
"node": "^18",

to include 16.x
or

matrix:
node-version: [16.x, 18.x]

to remove 16.x ?

Remove 16

Comment on lines -7 to +8
"node": ">=12",
"npm": ">=6"
"node": "^18",
"npm": "^9"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your engines change is causing all workflows that run install to fail.

@10xLaCroixDrinker 10xLaCroixDrinker deleted the feature/single-point-of-node-version_5.x.x branch May 3, 2024 20:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants