This repository has been archived by the owner on May 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: migrated express to fastify
feat(fastifycdn): migrate holocron cdn to fastify
fix: matching headers with existing express output
…o feature/express-fastify-migration
fix: exposing request and reply objects instead of raw
Size Change: +2.52 kB (0%) Total Size: 687 kB
ℹ️ View Unchanged
|
Matthew-Mallimo
previously approved these changes
Mar 2, 2023
Matthew-Mallimo
approved these changes
Mar 6, 2023
10xLaCroixDrinker
approved these changes
Mar 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExpressJS to Fastify migration. This is an internal change, API isn't being impacted.
Note: bringing fastify back to main after we reverted it and made it an experiment for more testing
Description
Migrating away from ExpressJS to improve performance, essentially be able to reduce time-to-start resolving a request, time-to-response, and handle more requests per second.
Small PRs have been raised for the team to easily review the changes:
#854
#856
#857
#859
#860
#865
This PR is the result of all these small PRs
Metrics
Fastify benchmark
Fastify runner + ExpressJS routes & logic (current implementation)
ExpressJS only
This is just to provide some context of the Fastify improvement so far
Motivation and Context
It improves requests performance
How Has This Been Tested?
Types of Changes
Checklist:
What is the Impact to Developers Using One App?